[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[netCDF #JKX-419612]: netcdf-4.1.2 patch for cxx4



Hi Alessandro,

> here is a patch we needed to compile cxx4 with AIX 6.1 xlC 10.1.

Thanks for reporting the bug and supplying the patch.  I'll incorporate this 
into our 
source distribution soon, along with a couple of other bug fixes for the 
netCDF-4 C++
API recently supplied by Lynton Appel, the original developer:

  I have noticed something else that needs to be changed:
  the examples in the documentation have include files that should be deleted
  as they are not required. The only include file required is referenced via:
  #include <netcdf>

  Others lines,
  #include<ncFile.h>
  #include<ncException.h>
  such as should be deleted

  also test_utilities.h isn't included. I am not sure (or cannot remember) 
where these 
  example filesare located and linked into the DOXYGEN documentation.

If you want to track progress on the bug fix, it's here:

  https://www.unidata.ucar.edu/jira/browse/NCF-72

--Russ
 
> diff -C4 -r netcdf-4.1.2.orig/cxx4/ncGroup.cpp netcdf-4.1.2/cxx4/ncGroup.cpp
> *** netcdf-4.1.2.orig/cxx4/ncGroup.cpp        2011-03-29 23:13:35.000000000 
> +0000
> --- netcdf-4.1.2/cxx4/ncGroup.cpp     2011-05-27 08:16:20.000000000 +0000
> ***************
> *** 217,225 ****
> }
> 
> // search in child groups of the children
> if(location == ChildrenOfChildrenGrps || location == AllChildrenGrps || 
> location == AllGrps ) {
> !     map<string,NcGroup>::iterator it;
> multimap<string,NcGroup> groups(getGroups(ChildrenGrps));
> for (it=groups.begin();it!=groups.end();it++) {
> multimap<string,NcGroup> childGroups(it->second.getGroups(AllChildrenGrps));
> ncGroups.insert(childGroups.begin(),childGroups.end());
> --- 217,225 ----
> }
> 
> // search in child groups of the children
> if(location == ChildrenOfChildrenGrps || location == AllChildrenGrps || 
> location == AllGrps ) {
> !     multimap<string,NcGroup>::iterator it;
> multimap<string,NcGroup> groups(getGroups(ChildrenGrps));
> for (it=groups.begin();it!=groups.end();it++) {
> multimap<string,NcGroup> childGroups(it->second.getGroups(AllChildrenGrps));
> ncGroups.insert(childGroups.begin(),childGroups.end());
> ***************
> *** 1250,1258 ****
> 
> // search in current group and parent groups.
> NcGroup tmpGroup(*this);
> multimap<string,NcDim>::iterator itD;
> !   map<string,NcVar>::iterator itV;
> while(1) {
> // get the collection of NcDim objects defined in this group.
> multimap<string,NcDim> dimTmp(tmpGroup.getDims());
> multimap<string,NcVar> varTmp(tmpGroup.getVars());
> --- 1250,1258 ----
> 
> // search in current group and parent groups.
> NcGroup tmpGroup(*this);
> multimap<string,NcDim>::iterator itD;
> !   multimap<string,NcVar>::iterator itV;
> while(1) {
> // get the collection of NcDim objects defined in this group.
> multimap<string,NcDim> dimTmp(tmpGroup.getDims());
> multimap<string,NcVar> varTmp(tmpGroup.getVars());
> ***************
> *** 1288,1296 ****
> 
> // search in current group and parent groups.
> multimap<string,NcDim>::iterator itD;
> NcGroup tmpGroup(*this);
> !   map<string,NcVar>::iterator itV;
> while(1) {
> // get the collection of NcDim objects defined in this group.
> multimap<string,NcDim> dimTmp(tmpGroup.getDims());
> multimap<string,NcVar> varTmp(tmpGroup.getVars());
> --- 1288,1296 ----
> 
> // search in current group and parent groups.
> multimap<string,NcDim>::iterator itD;
> NcGroup tmpGroup(*this);
> !   multimap<string,NcVar>::iterator itV;
> while(1) {
> // get the collection of NcDim objects defined in this group.
> multimap<string,NcDim> dimTmp(tmpGroup.getDims());
> multimap<string,NcVar> varTmp(tmpGroup.getVars());
> 
> 

Russ Rew                                         UCAR Unidata Program
address@hidden                      http://www.unidata.ucar.edu



Ticket Details
===================
Ticket ID: JKX-419612
Department: Support netCDF
Priority: Normal
Status: Closed